-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix heroku 1 click #1055
Open
aapomm
wants to merge
28
commits into
develop
Choose a base branch
from
fix-heroku-1-click
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix heroku 1 click #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b526c08.
aapomm
commented
Jul 29, 2022
@@ -10,7 +10,7 @@ spec: | |||
value: enabled | |||
scope: RUN_TIME | |||
git: | |||
branch: develop | |||
branch: fix-heroku-1-click |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be reverted to develop
once merged/before merging.
aapomm
force-pushed
the
fix-heroku-1-click
branch
from
November 28, 2022 09:48
5d15629
to
6c9dbd5
Compare
… fix-heroku-1-click
aapomm
force-pushed
the
fix-heroku-1-click
branch
from
April 27, 2023 08:46
e558b31
to
cc6dc84
Compare
aapomm
force-pushed
the
fix-heroku-1-click
branch
from
April 27, 2023 08:52
cc6dc84
to
022aad2
Compare
aapomm
force-pushed
the
fix-heroku-1-click
branch
from
May 11, 2023 08:25
3b465cc
to
8d30f6d
Compare
aapomm
force-pushed
the
fix-heroku-1-click
branch
from
April 4, 2024 09:17
eb4a091
to
d1a64f8
Compare
aapomm
force-pushed
the
fix-heroku-1-click
branch
from
April 4, 2024 09:41
d1a64f8
to
da15fa2
Compare
etdsoft
reviewed
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec
Errors for 1 click deploy:
This seems to be caused by the Ruby 3 removing Webrick as a bundled gem. Previously, the deployed app uses Webrick by default when being deployed.
Proposed solution
The solution I went with is moving the Puma gem outside of the development group in the Gemfile allowing it to be installed and used on deploy.
Other Information
If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.
Thanks for contributing to Dradis!
Copyright assignment
Collaboration is difficult with commercial closed source but we want
to keep as much of the OSS ethos as possible available to users
who want to fix it themselves.
In order to unambiguously own and sell Dradis Framework commercial
products, we must have the copyright associated with the entire
codebase. Any code you create which is merged must be owned by us.
That's not us trying to be a jerks, that's just the way it works.
Please review the CONTRIBUTING.md
file for the details.
You can delete this section, but the following sentence needs to
remain in the PR's description:
Check List