Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix $DRACULA_ARROW_ICON getting parsed as a command-line flag to print #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

speelbarrow
Copy link

When $DRACULA_ARROW_ICON begins with an unescaped - character, it will be read as a command line flag by the print command. This causes the error dracula_arrow:print:2: bad option: -> (for example) to get outputted on each new prompt line. This PR passes the -- flag to print before passing $DRACULA_ARROW_ICON to ensure that print does not attempt to parse the arrow icon as a command-line flag.

If you're fixing a UI issue, make sure you take two screenshots. One that shows the actual bug and another that shows how you fixed it.

Before:
Screenshot 2023-05-31 at 9 24 18 AM
After:
Screenshot 2023-05-31 at 9 24 47 AM

Note: the literal string value of $DRACULA_ARROW_ICON in this context is -> , I'm using a font with ligatures that merges those two first characters into one symbol.

…rint`

When `$DRACULA_ARROW_ICON` begins with an unescaped `-` character, it will be read as a command line flag by the `print` command. This causes the error `dracula_arrow:print:2: bad option: -> ` (for example) to get outputted on each new prompt line. This PR passes the `--` flag to `print` before passing `$DRACULA_ARROW_ICON` to ensure that `print` does not attempt to parse the arrow icon as a command-line flag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant