Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some of the inconsistencies in gnome 40 #106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AgathaSorceress
Copy link

@AgathaSorceress AgathaSorceress commented Apr 7, 2021

An attempt at fixing the background color and the dash menu in gnome-shell v40. (#105) There are still quite a few new bugs which appeared after the update that I couldn't fix but this should at least fix the most obvious ones.

before fix
after fix

I'm not sure if I'll be able to fix more things with this PR (I'll try, at least), but here are some of the remaining bugs I've noticed so far:

  • no visual response when selecting apps in dash, fullscreen app picker menu or hovering over search results
  • the separator between pinned and unpinned apps in the dash doesn't seem to be themed
  • the open folder menu in the app picker is no longer themed
  • some visual small glitches due to the use of transparency in the overview menu
  • the Gnome Terminal background tries to be transparent and breaks
  • the default Extensions, GTK Demo, Icon Browser and Widget Factory apps are no longer themed
  • workspace switcher at the top is too small and the empty space padding around workspaces in the middle is way too much (could be personal preference)
  • some top bar buttons can get doubled highlighting on hover which sometimes doesn't go away when unhovered

@vltr
Copy link

vltr commented Apr 9, 2021

This already makes a lot of things usable. One "big" change we got on Gnome Shell 40 is how the dock now have some different theme classes, as can be checked out here 😉

@menezesfelipee
Copy link

Perfect!!! Thank you!

@peterlobster
Copy link

This patch has some issues now applying...

git apply --check 106.patch
error: patch failed: gnome-shell/_common.scss:1378
error: gnome-shell/_common.scss: patch does not apply
error: patch failed: gnome-shell/gnome-shell.css:1236
error: gnome-shell/gnome-shell.css: patch does not apply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants