-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: restructure test suite #27
Conversation
3870711
to
81e8118
Compare
This is a first step to making the tests faster. 19 instead of 25 minutes. What do you think @hsluytergaethje? |
@afuetterer Thanks a lot for working on making the tests faster. But I think we should put this on hold until we solved a few architectural issues in pydracor. One of them being that the tests currently always run against the production system, which, given the high load they cause on the API, is not a good idea. We already scheduled a discussion of the issues for late January. Please keep the PR open and stay tuned. |
Are there any updates on this? |
@afuetterer Can we rebase the We should then merge the PR since it reorganises the tests in a good way, but probably still disable the workflow or set it up so that it needs to be triggered manually. The tests still run 19min and put an unnecessary load on the production system. I wouldn't won't this to be executed automatically on every push. We are still discussing how to restructure the library but a major overhaul looks very likely right now. So for the time being more work on the tests themselves is probably not a good idea. |
Yes, sure. I wanted to propose to "record" responses from the API using vcr.py, so the production system is only queried once when recording and not during testing (proposed in #24). But sure, go ahead and restructure the library first. I thought you had a discussion about that in January. Do you want to follow up on #7? |
@afuetterer Thanks for rebasing! Since the tests now fail I'm going to disable the work flow for now, though.
I closed #24 because optimizing test on something that needs to be replaced seems like a waste of time.
We are planning to use some code generation framework for the next pydracor version. However, since nobody here is working full-time on it, it may take some time. Please stay tuned. |
This PR proposes the following changes:
I would like to propose some more enhancements to the test suite. But this initial restructuring could be a starting point. What do you think?