forward uas CANCEL request header to uac CANCEL request #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need more of a description of what problem we are trying to solve here. I would like to see an issue created with full details that this PR links to before I will accept the changes |
davehorton
requested changes
Jul 14, 2023
lib/srf.js
Outdated
| debug('createB2BUA: received CANCEL from A party, sending CANCEL to B'); | ||
| res.send(487) ; | ||
| uacReq.cancel() ; | ||
| uacReq.cancel({ | ||
| headers: copyUASHeaderToUAC(cancelReq) |
There was a problem hiding this comment.
what if there is no cancelReq? This doesnt seem backwards compatible
There was a problem hiding this comment.
if there is no cancelReq, function copyUASHeaderToUAC return empty object {}, nothing will be added for UAC cancel. so it's still backwards compatible
There was a problem hiding this comment.
My concern is this PR use opts. proxyRequestHeaders for both invite and cancel requests. Not sure this is a good approach.
davehorton
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#150