fix: initialize v8 on main thread to prevent random linux errors (#74)

Cargo.toml

@@ -6,7 +6,7 @@ members = [
 ]
 
 [workspace.dependencies]
-deno_core = "0.238.0"
+deno_core = "0.243.0"
 dprint-core = "0.65.0"
 serde = { version = "1.0.149", features = ["derive"] }
 serde_json = { version = "1.0", features = ["preserve_order"] }

base/src/runtime.rs

@@ -41,6 +41,11 @@ impl JsRuntime {
     }
   }
 
+  /// Call this once on the main thread.
+  pub fn initialize_main_thread() {
+    deno_core::JsRuntime::init_platform(None)
+  }
+
   pub async fn execute_format_script(&mut self, code: String) -> Result<Option<String>, Error> {
     let global = self.inner.execute_script("format.js", code.into())?;
     let resolve = self.inner.resolve(global);

js/node/package.json

@@ -40,7 +40,6 @@
   "dependencies": {
     "buffer": "^6.0.3",
     "prettier": "^3.1.1",
-    "prettier-plugin-astro": "^0.12.3",
     "prettier-plugin-jsdoc": "^1.3.0",
     "prettier-plugin-svelte": "^3.1.2",
     "process": "^0.11.10",

plugin/Cargo.toml

@@ -4,22 +4,22 @@ version = "0.32.0"
 edition = "2021"
 
 [dependencies]
-deno_console = "0.129.0"
+deno_console = "0.130.0"
 deno_core = { workspace = true }
-deno_url = "0.129.0"
-deno_webidl = "0.129.0"
+deno_url = "0.130.0"
+deno_webidl = "0.130.0"
 dprint-core = { workspace = true, features = ["process"] }
 dprint-plugin-deno-base = { version = "0.1.0", path = "../base" }
 once_cell = "1.18"
 serde = { workspace = true }
 serde_json = { workspace = true }
 
 [build-dependencies]
-deno_console = "0.129.0"
+deno_console = "0.130.0"
 deno_core = { workspace = true, features = ["include_js_files_for_snapshotting"] }
 dprint-plugin-deno-base = { version = "0.1.0", features = ["build"], path = "../base" }
-deno_url = "0.129.0"
-deno_webidl = "0.129.0"
+deno_url = "0.130.0"
+deno_webidl = "0.130.0"
 sha256 = "1.4.0"
 zstd = "0.13.0"
 

plugin/src/main.rs

@@ -1,6 +1,7 @@
 use dprint_core::plugins::process::get_parent_process_id_from_cli_args;
 use dprint_core::plugins::process::handle_process_stdio_messages;
 use dprint_core::plugins::process::start_parent_process_checker_task;
+use dprint_plugin_deno_base::runtime::JsRuntime;
 use dprint_plugin_deno_base::util::create_tokio_runtime;
 use handler::PrettierPluginHandler;
 
@@ -9,6 +10,7 @@ mod formatter;
 mod handler;
 
 fn main() {
+  JsRuntime::initialize_main_thread();
   let runtime = create_tokio_runtime();
   let result = runtime.block_on(async {
     if let Some(parent_process_id) = get_parent_process_id_from_cli_args() {

scripts/create_for_testing.ts

@@ -0,0 +1,21 @@
+#!/usr/bin/env -S deno run -A
+
+// Script for quickly creating the plugin for testing purposes on Windows
+// To run:
+// 1. Run `./scripts/create_plugin_file.ts`
+// 2. Update dprint.json to point at ./target/release/plugin.json then update checksum
+//    as shown when initially run.
+
+import $ from "dax";
+
+await $`deno task build`;
+await $`cargo build --release`;
+if (Deno.build.os === "windows") {
+  await $`powershell -Command ${"Compress-Archive -Force -Path target/release/dprint-plugin-prettier.exe -DestinationPath target/release/dprint-plugin-prettier-x86_64-pc-windows-msvc.zip"}`;
+} else if (Deno.build.os === "linux") {
+  await $`zip -j target/release/dprint-plugin-prettier-x86_64-unknown-linux-gnu.zip target/release/dprint-plugin-prettier`;
+} else {
+  throw "TODO";
+}
+
+await $`cd target/release && deno run -A ../../scripts/create_plugin_file.ts --test`;

scripts/local_test.ts

@@ -0,0 +1,11 @@
+import $ from "dax";
+import { getChecksum } from "https://raw.githubusercontent.com/dprint/automation/0.8.1/hash.ts";
+
+await $`./scripts/create_for_testing.ts`;
+const checksum = await getChecksum($.path("./target/release/plugin.json").readBytesSync());
+const dprintConfig = $.path("dprint.json");
+const data = dprintConfig.readJsonSync();
+const index = data.plugins.findIndex(d => d.startsWith("./target") || d.includes("prettier"));
+data.plugins[index] = `./target/release/plugin.json@${checksum}`;
+dprintConfig.writeJsonPrettySync(data);
+await $`dprint fmt`;

scripts/update.ts

@@ -11,7 +11,7 @@ $.logStep("Upgrading prettier...");
 const jsNodePath = rootDirPath.join("./js/node");
 await $`npm install`.cwd(jsNodePath);
 await $`npm install --save prettier`.cwd(jsNodePath);
-await $`npm install --save prettier-plugin-astro`.cwd(jsNodePath);
+// await $`npm install --save prettier-plugin-astro`.cwd(jsNodePath);
 await $`npm install --save prettier-plugin-jsdoc`.cwd(jsNodePath);
 await $`npm install --save prettier-plugin-svelte`.cwd(jsNodePath);