Fix system priviledged port range, excluding port 1024 that is not re…

…served. (Haivision#812)
dprestegard · Aug 19, 2019 · 79b898f · 79b898f
1 parent 553b24a
commit 79b898f
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 13 deletions.
diff --git a/ATTIC/srt-multiplex.cpp b/ATTIC/srt-multiplex.cpp
@@ -566,9 +566,9 @@ int main( int argc, char** argv )
     }
 
     int iport = atoi(up.port().c_str());
-    if ( iport <= 1024 )
+    if ( iport < 1024 )
     {
-        cerr << "Port value invalid: " << iport << " - must be >1024\n";
+        cerr << "Port value invalid: " << iport << " - must be >=1024\n";
         return 1;
     }
 

diff --git a/apps/transmitmedia.cpp b/apps/transmitmedia.cpp
@@ -1213,9 +1213,9 @@ extern unique_ptr<Base> CreateMedium(const string& uri)
 
     case UriParser::SRT:
         iport = atoi(u.port().c_str());
-        if ( iport <= 1024 )
+        if ( iport < 1024 )
         {
-            cerr << "Port value invalid: " << iport << " - must be >1024\n";
+            cerr << "Port value invalid: " << iport << " - must be >=1024\n";
             throw invalid_argument("Invalid port number");
         }
         ptr.reset( CreateSrt<Base>(u.host(), iport, u.parameters()) );
@@ -1224,9 +1224,9 @@ extern unique_ptr<Base> CreateMedium(const string& uri)
 
     case UriParser::UDP:
         iport = atoi(u.port().c_str());
-        if ( iport <= 1024 )
+        if ( iport < 1024 )
         {
-            cerr << "Port value invalid: " << iport << " - must be >1024\n";
+            cerr << "Port value invalid: " << iport << " - must be >=1024\n";
             throw invalid_argument("Invalid port number");
         }
         ptr.reset( CreateUdp<Base>(u.host(), iport, u.parameters()) );

diff --git a/examples/suflip.cpp b/examples/suflip.cpp
@@ -624,7 +624,7 @@ int main( int argc, char** argv )
 
     if ( su.portno() < 1024 || tu.portno() < 1024 )
     {
-        cerr << "Port number must be > 1024\n";
+        cerr << "Port number must be >= 1024\n";
         return 1;
     }
 

diff --git a/testing/srt-test-multiplex.cpp b/testing/srt-test-multiplex.cpp
@@ -565,9 +565,9 @@ int main( int argc, char** argv )
     }
 
     int iport = atoi(up.port().c_str());
-    if ( iport <= 1024 )
+    if ( iport < 1024 )
     {
-        cerr << "Port value invalid: " << iport << " - must be >1024\n";
+        cerr << "Port value invalid: " << iport << " - must be >=1024\n";
         return 1;
     }
 

diff --git a/testing/testmedia.cpp b/testing/testmedia.cpp
@@ -1261,9 +1261,9 @@ extern unique_ptr<Base> CreateMedium(const string& uri)
 
     case UriParser::SRT:
         iport = atoi(u.port().c_str());
-        if ( iport <= 1024 )
+        if ( iport < 1024 )
         {
-            cerr << "Port value invalid: " << iport << " - must be >1024\n";
+            cerr << "Port value invalid: " << iport << " - must be >=1024\n";
             throw invalid_argument("Invalid port number");
         }
         ptr.reset( CreateSrt<Base>(u.host(), iport, u.parameters()) );
@@ -1272,9 +1272,9 @@ extern unique_ptr<Base> CreateMedium(const string& uri)
 
     case UriParser::UDP:
         iport = atoi(u.port().c_str());
-        if ( iport <= 1024 )
+        if ( iport < 1024 )
         {
-            cerr << "Port value invalid: " << iport << " - must be >1024\n";
+            cerr << "Port value invalid: " << iport << " - must be >=1024\n";
             throw invalid_argument("Invalid port number");
         }
         ptr.reset( CreateUdp<Base>(u.host(), iport, u.parameters()) );