Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crc32c's __main__ for Python 3 #2298

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

Jongy
Copy link

@Jongy Jongy commented Jan 25, 2022

By the way, pylint-dev/pylint#2571 was fixed in pylint 2.10, but I see that we're using 2.6 so I don't want to do the upgrade in this small fix PR.


This change is Reviewable

@wbarnha wbarnha added the wontfix label Aug 3, 2023
@wbarnha
Copy link
Collaborator

wbarnha commented Aug 3, 2023

Thanks for the PR! Unfortunately, support for Python 2.6 is long-gone at this point. Runners for 2.7 on GitHub are no longer available, so we can't formally verify that the library supports Python 2.

@wbarnha wbarnha closed this Aug 3, 2023
@wbarnha wbarnha reopened this Aug 3, 2023
@wbarnha wbarnha removed the wontfix label Aug 3, 2023
@wbarnha
Copy link
Collaborator

wbarnha commented Aug 3, 2023

Misread the PR, sorry. Let's remove the six import and get it on its way. https://stackoverflow.com/a/58116896/9852671 provided a helpful explanation that sys.buffer is intended for bytes.

@Jongy Jongy force-pushed the fix-crc32c-main branch from 356f493 to 07164c1 Compare August 3, 2023 07:45
@Jongy
Copy link
Author

Jongy commented Aug 3, 2023

Updated @wbarnha :)

wbarnha and others added 11 commits March 7, 2024 10:31
…terations for Kafka 0.8.2 and Python 3.12 (dpkp#159)

* skip failing tests for PyPy since they work locally

* Reconfigure tests for PyPy and 3.12

* Skip partitioner tests in test_partitioner.py if 3.12 and 0.8.2

* Update test_partitioner.py

* Update test_producer.py

* Timeout tests after ten minutes

* Set 0.8.2.2 to be experimental from hereon

* Formally support PyPy 3.9
* Test Kafka 0.8.2.2 using Python 3.11 in the meantime

* Override PYTHON_LATEST conditionally in python-package.yml

* Update python-package.yml

* add python annotation to kafka version test matrix

* Update python-package.yml

* try python 3.10
* Remove support for EOL'ed versions of Python

* Update setup.py
Too many MRs to review... so little time.
After stop/start kafka service, kafka-python may use 100% CPU caused by
busy-retry while the socket was closed. This fix the issue by unregister
the socket if the fd is negative.

Co-authored-by: Orange Kao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants