Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVOPS-248] Migrate CircleCI to Github actions #1313

Merged
merged 12 commits into from
Sep 20, 2023

Conversation

MarkCalvert
Copy link
Contributor

Motivation and Context

JIRA issue: https://salsadigital.atlassian.net/browse/DEVOPS-248

Changed

  1. Created new Github action workflows based off current CircleCI implementation

Screenshots

Screenshot 2023-08-15 at 11 00 39 AM

How Has This Been Tested?

  • Tested Github action workflow commit

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist

  • I've added relevant changes to the documentation.
  • I have added tests to cover my changes (if not applicable, please state why)
  • My change requires a template update for create-ripple-app.
  • I have added template update script for next release.

@MarkCalvert MarkCalvert force-pushed the feature/migrating-circleci-to-github-actions branch from 2a2c3d4 to faa43c5 Compare August 30, 2023 00:30
@tim-yao
Copy link
Contributor

tim-yao commented Aug 30, 2023

@MarkCalvert @FleetAdmiralButter The ci trigger is not working:

 Triggering end to end testing for ripple...
Error: No E2E GitHub token found, end to end is not triggered. Please make sure E2E_GITHUB_TOKEN is set up.

Do we need to wait for the middleware to work first then we can test it?

@MarkCalvert
Copy link
Contributor Author

@tim-yao, a few things are required to test the CI nightwatch trigger.
First, a GitHub access token must be added to the lagoon project for E2E_GITHUB_TOKEN. This token and API call will get replaced with the middleware work.
Secondly, unfortunately and annoyingly workflow dispatches can not be tested until they are merged into the default branch which is not ideal. https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_dispatch
I will see if there is a workaround.

@tim-yao
Copy link
Contributor

tim-yao commented Aug 30, 2023

@MarkCalvert ok. Can you please use your own GitHub token to call the same curl request from your local? Then we can see if it works.

@MarkCalvert
Copy link
Contributor Author

Hi @tim-yao,
Using the GitHub CLI tool, I found a workaround to trigger the nightwatch workflow for testing.
Here is the gh CLI command you can run from the locally cloned repo.
gh workflow run nightwatch.yml --ref feature/migrating-circleci-to-github-actions -f e2e=true -f e2e_project=reference -f e2e_be_url=https://develop.content.reference.sdp.vic.gov.au -f e2e_fe_url=https://app.pr-1313.ripple.sdp4.sdp.vic.gov.au/

You can view the actions I have triggered for the nightwatch workflow and will notice they fail in the e2e reusable workflow tests, can you please review these?

@MarkCalvert
Copy link
Contributor Author

@tim-yao I have disabled the workflows by updating the on event branches to a name that does not exist, so they will not be triggered on master and uat pushes.
06c07d9

@tim-yao tim-yao merged commit 0ee3c05 into develop Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants