Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDPAP-7958] fix for in page nav links breaking on refresh/share #1310

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Aug 4, 2023

Motivation and Context

JIRA issue: https://digital-vic.atlassian.net/browse/SDPAP-7958

Changed

  1. Any in page nav item that started with a number would break the page once clicked and refreshed, shared or opened in a new tab (on solar vic), this was due to the fact that IDs starting with a numbers make for an invalid selectors
Screenshot 2023-08-04 at 5 35 33 pm

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist

  • I've added relevant changes to the documentation.
  • I have added tests to cover my changes (if not applicable, please state why)
  • My change requires a template update for create-ripple-app.
  • I have added template update script for next release.

@lambry lambry merged commit bdb47fc into develop Aug 17, 2023
@lambry lambry deleted the bugfix/SDPAP-7958-scroll-to-hash branch August 17, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants