Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDPAP-7784] reset forms conditional state after clearing the form #1301

Merged
merged 3 commits into from
May 26, 2023

Conversation

lambry
Copy link
Contributor

@lambry lambry commented May 22, 2023

Motivation and Context

JIRA issue: https://digital-vic.atlassian.net/browse/SDPAP-7784

Changed

Fields were being cleared when the clear form button is pressed but the actually form state isn't returned to it's initial state, i.e. with conditional logic applied.

Let me know if anyone's got some suggestions to avoid using this.$refs.vfg.$forceUpdate().

Screenshots

Before

clearform-before

After

clearform-after

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist

  • I've added relevant changes to the documentation.
  • I have added tests to cover my changes (if not applicable, please state why)
  • My change requires a template update for create-ripple-app.
  • I have added template update script for next release.

@lambry lambry self-assigned this May 22, 2023
@lambry lambry marked this pull request as ready for review May 22, 2023 22:51
@lambry lambry merged commit 8ffa5bd into develop May 26, 2023
@lambry lambry deleted the bugfix/SDPAP-7784-conditional-logic-clear-button branch May 26, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants