-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDPA-5684] Added a visually hidden list of all validation errors for screenreaders. #1078
base: develop
Are you sure you want to change the base?
Conversation
&__sr-only { | ||
@include rpl_visually_hidden; | ||
ul { | ||
// Avoid screenreader reading out "bullet". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this go in the rpl_visually_hidden mixin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dylankelly I'm not really sure whether I understand. Can you explain it a bit more? I'm just using the standard rpl_visually_hidden
mixin to visually hide the messages. You mean using the rpl-visually-hidden
class instead? I wrapped it in the custom _sr-only
just because it needed the extra UL treatment. I guess it could be reshuffled if that's what you mean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah maybe i didnt think that through first. What I was probably intending was a list reset mixin that included this.
Motivation and Context
JIRA issue: https://digital-engagement.atlassian.net/browse/SDPA-5684
Changed
Screenshots
Without PR 1074
With PR 1074
How Has This Been Tested?
Types of changes
Checklist