[WIP] add URI matching for 'rbw get' #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proxict
force-pushed
the
feature/url-match
branch
2 times, most recently
from
447b075 to
65f954b
Compare
|
@doy May I please ask you for code review? |
proxict
force-pushed
the
feature/url-match
branch
from
65f954b to
a864366
Compare
|
this looks basically good - i'll merge this now and follow up with a few fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request aims to address this issue: #26
I'd appreciate a preliminary code-review (it's far from finished), I just want to get some feedback before I spend more time on something that is potentially flawed.
Please, keep in mind I am completely new to Rust - I am not at all versed with Rust's idioms and other bells and whistles.
That being said, I am looking for any constructive criticism I can get.