Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/oie tests #141

Closed
wants to merge 11 commits into from
Closed

Feature/oie tests #141

wants to merge 11 commits into from

Conversation

fsilvamaia
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@fsilvamaia fsilvamaia marked this pull request as ready for review November 9, 2023 18:34
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 10, 2023
View reviewed changes
tokendito/okta.py
logger.debug(f"Authenticate user to {config.okta['org']}")
logger.debug(f"Sending {headers}, {payload} to {config.okta['org']}")
logger.debug(f"Authenticate user to {config.okta['authentication_server']}")
logger.debug(f"Sending {headers}, {payload} to {config.okta['authentication_server']}")

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information High

This expression logs
sensitive data (password)
Loading
as clear text.
@sevignyj sevignyj closed this Nov 13, 2023
@sevignyj sevignyj deleted the feature/oie_tests branch November 17, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsilvamaia @sevignyj