Add a simple frontend #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
suggested changes
Dec 10, 2017
| @@ -94,8 +94,14 @@ func (h handler) redirect(w http.ResponseWriter, r *http.Request) { | |||
|
|
|||
| model, err := h.storage.Load(code) | |||
| if err != nil { | |||
| w.WriteHeader(http.StatusNotFound) | |||
| w.Write([]byte("URL Not Found")) | |||
| data, err := ioutil.ReadFile("frontend/index.html") | |||
There was a problem hiding this comment.
It's better to use there http.ServeFile(). So you don't need to handle errors etc.
There was a problem hiding this comment.
Huh! I didn't know about that... thanks for pointing that out. I will check this one also.
| const inputField = document.querySelector('.urltochange'); | ||
| const shortenButton = document.querySelector('.button'); | ||
| const requestURL = "/encode/" | ||
| const xhr = new XMLHttpRequest(); |
There was a problem hiding this comment.
You start there by using ECMA6, so why not using directly the new Fetch API which was introduced in ECMA6?
There was a problem hiding this comment.
@maxibanki Good point, thanks for bringing this up!
I'm fairly new to JS so I don't know all the tools yet. I will take a look and see how to make this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a simple frontend for the URL shortener