Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds score variable to matched / sorted results and multi model support #48

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

brez
Copy link

@brez brez commented Jul 22, 2013

Makes the matching score available for use inside the instance.

@brez
Copy link
Author

brez commented Jul 22, 2013

Just added this multi model support as well - tests written / all passing with rake test

@brez
Copy link
Author

brez commented Jul 22, 2013

Looks like the CI is busted - here's my local result

Finished tests in 4.481758s, 12.9414 tests/s, 52.8810 assertions/s.

58 tests, 237 assertions, 0 failures, 0 errors, 0 skips

@dougal
Copy link
Owner

dougal commented Jul 24, 2013

CI has been intermittently failing for some Ruby/Rails versions for a while. Not sure why, they always run fine locally.

The score instance variable patch is almost insta-merge, though I'm not sure about the name as it seems it might clash with other libraries or even user defined attributes. I'd prefer not to add yet more configuration for this, perhaps calling it search_score or something less generic.

I'll need to look at the Multi-Model patch more closely, but it looks great on first pass.

Thanks!

@brez
Copy link
Author

brez commented Aug 1, 2013

Please see:

[master 0647300] changes score variable name to the less generic search_score

Also:

Finished tests in 4.481221s, 12.9429 tests/s, 52.8874 assertions/s.

58 tests, 237 assertions, 0 failures, 0 errors, 0 skips

@brez
Copy link
Author

brez commented Jun 2, 2016

Should I just close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants