fix: pass_thru behavior when the proc is spec-ed via a Proc as last argument #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rgument v2.4.1 broke backward compatibility in the following case: with(some, arguments, Proc).pass_thru In that case, the block would be given as positional argument to the original method, instead of being passed as a block.
doudou
force-pushed
the
fix_24_pass_thru_with_proc
branch
from
2e7f854 to
2e7a888
Compare
g-arjones
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2.4.1 broke backward compatibility in the following case:
with(some, arguments, Proc).pass_thru
In that case, the block would be given as positional argument to the original method, instead of being passed as a block.