Restore index caching #1504
Merged
Restore index caching #1504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinPicard
force-pushed
the
restore_index_caching
branch
from
8364ccd to
d54b0de
Compare
Closed
|
Yep, caching was failing due to the absence of serialization support in the very early versions of |
torymur
approved these changes
Mar 18, 2025
rlouf
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #1466
Caching for the creation of the states mapping in the
RegexGuidewas removed in PR #1278 to address issue #1274 highlighting that the cache is causing an error.As I cannot reproduce the error with the v1.0 branch of Outlines using
outlines_core==0.1.26, I propose we simply restore the cache on the functioncached_create_states_mapping(and add tests for it).