Addressed the issue where CapTransaction was not disposed when the tr…

…ansaction failed for sql server. (#1521)
dotnetcore · May 7, 2024 · 65cb6b2 · 65cb6b2
1 parent 9e53295
commit 65cb6b2
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/src/DotNetCore.CAP.SqlServer/Diagnostics/DiagnosticObserver.cs b/src/DotNetCore.CAP.SqlServer/Diagnostics/DiagnosticObserver.cs
@@ -45,10 +45,14 @@ public void OnNext(KeyValuePair<string, object?> evt)
                     if (_transBuffer.TryRemove(transactionKey, out var transaction))
                     {
                         if (GetProperty(evt.Value, "Operation") as string == "Rollback")
+                        {
+                            transaction.Dispose();
                             return;
+                        }
+
                         transaction.DbTransaction = new NoopTransaction();
                         transaction.Commit();
-                        transaction.Dispose(); 
+                        transaction.Dispose();
                     }
 
                     break;
@@ -61,7 +65,10 @@ public void OnNext(KeyValuePair<string, object?> evt)
                         if (!TryGetSqlConnection(evt, out var sqlConnection)) return;
                         var transactionKey = sqlConnection.ClientConnectionId;
 
-                        _transBuffer.TryRemove(transactionKey, out _);
+                        if (_transBuffer.TryRemove(transactionKey, out var transaction))
+                        {
+                            transaction.Dispose();
+                        }
                     }
 
                     break;