-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Typed): override Equals method #5293
Conversation
Reviewer's Guide by SourceryThis pull request refactors the TypedOptions class to override the Equals method for proper comparison of TypedOptions objects. This change also updates the Typed component to use the Equals method for change detection. Sequence diagram for TypedOptions comparisonsequenceDiagram
participant Typed as Typed Component
participant Options as TypedOptions
Typed->>Options: UpdateParameters()
Note over Options: Check if Options changed
Options->>Options: Equals(TypedOptions)
Options->>Options: EqualText(List<string>)
Options-->>Typed: Return comparison result
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- The GetHashCode override should be implemented to be consistent with Equals by combining the hash codes of all fields used in the equality comparison. Using base.GetHashCode() violates the contract that equal objects must have equal hash codes.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5293 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 642 642
Lines 28846 28873 +27
Branches 4100 4103 +3
=========================================
+ Hits 28846 28873 +27 ☔ View full report in Codecov by Sentry. |
override Equals method
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5292
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Override the Equals method for the TypedOptions class.
Bug Fixes:
Tests: