Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DriverJs): the PrevBtnText NextBtnTetxt not working #5288

Merged
merged 16 commits into from
Feb 3, 2025
Merged

Conversation

ArgoZhang
Copy link
Collaborator

@ArgoZhang ArgoZhang commented Feb 3, 2025

the PrevBtnText NextBtnTetxt not working

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #5280

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Documentation:

  • Document the usage of BootstrapBlazor.DriverJs.

Copy link

sourcery-ai bot commented Feb 3, 2025

Reviewer's Guide by Sourcery

This pull request fixes an issue where the PrevBtnText and NextBtnText properties were not working in the DriverJs component. The fix involves adding a PackageTips component to the DriverDotnetJs.razor file.

Sequence diagram for DriverJs navigation button text flow

sequenceDiagram
    participant User
    participant DriverJs
    participant PackageTips

    User->>DriverJs: Set PrevBtnText/NextBtnText
    DriverJs->>PackageTips: Initialize with package info
    PackageTips-->>DriverJs: Package information displayed
    DriverJs-->>User: Navigation with custom button text
Loading

Class diagram for DriverJs component structure

classDiagram
    class DriverDotnetJs {
        +Render()
    }
    class PackageTips {
        +string Name
        +Render()
    }
    DriverDotnetJs --> PackageTips : uses
    note for DriverDotnetJs "Added PackageTips integration"
Loading

File-Level Changes

Change Details Files
Added PackageTips component to the DriverDotnetJs.razor file.
  • Added <PackageTips Name="BootstrapBlazor.DriverJs" /> to the DriverDotnetJs.razor file.
src/BootstrapBlazor.Server/Components/Samples/DriverDotnetJs.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#5280 Ensure that NextBtnText, PrevBtnText, and DoneBtnText settings are correctly applied in DriverJs configuration The provided diff does not show any changes related to button text configuration or fixing the DriverJs settings. The changes only add a PackageTips component to a Razor file and update a project file.
#5280 Fix the button text not changing when configured in DriverJsConfig There are no code modifications that would resolve the issue of button texts not being applied as specified in the configuration.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the bug Something isn't working label Feb 3, 2025
@bb-auto bb-auto bot added this to the v9.3.0 milestone Feb 3, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The PR title contains a typo ('NextBtnTetxt') and should be corrected. Additionally, please ensure the description clearly explains how the changes fix the button text issue.
  • Please complete all relevant sections of the PR template in English to help maintain clear communication across the project.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (786e73c) to head (bba9e58).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5288   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          640       640           
  Lines        28791     28791           
  Branches      4092      4092           
=========================================
  Hits         28791     28791           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 9079726 into main Feb 3, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the fix-driverjs branch February 3, 2025 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(DriverJs): the PrevBtnText NextBtnTetxt not working
1 participant