-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(WebClientService): add TimeoutException catch #5283
Conversation
Reviewer's Guide by SourceryThis pull request implements a TimeoutException catch in the WebClientService and adjusts the Drawer and Affix components to use string interpolation. Sequence diagram for WebClientService GetClientInfo with timeout handlingsequenceDiagram
participant Client
participant WebClientService
participant TaskCompletionSource
Client->>WebClientService: GetClientInfo()
WebClientService->>TaskCompletionSource: Task.WaitAsync(3 seconds)
alt Timeout occurs
TaskCompletionSource-->>WebClientService: TimeoutException
Note over WebClientService: Catch and suppress TimeoutException
else Other error occurs
TaskCompletionSource-->>WebClientService: Other Exception
WebClientService->>WebClientService: Log error
end
WebClientService-->>Client: Return ClientInfo
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding logging for TimeoutException similar to how other exceptions are handled to aid in debugging production issues
- Please document the rationale for increasing the timeout duration from 1 to 3 seconds
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5283 +/- ##
========================================
Coverage 99.99% 100.00%
========================================
Files 640 640
Lines 28781 28782 +1
Branches 4092 4090 -2
========================================
+ Hits 28779 28782 +3
+ Partials 2 0 -2 ☔ View full report in Codecov by Sentry. |
add TimeoutException catch
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5282
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: