-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(BootstrapLabelSetting): add BootstrapLabelSetting component #5274
Conversation
This reverts commit 37653dc.
Reviewer's Guide by SourceryThis pull request introduces a new Sequence diagram showing how BootstrapLabel resolves its LabelWidthsequenceDiagram
participant BL as BootstrapLabel
participant BLS as BootstrapLabelSetting
participant CB as CssBuilder
BL->>BL: OnParametersSet()
alt LabelWidth not set
BL->>BLS: Get cascading LabelWidth
BLS-->>BL: Return LabelWidth value
end
BL->>CB: AddStyle("--bb-row-label-width", width)
CB-->>BL: Return style string
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- There's a typo in the test assertions - 'widht' should be 'width' in AddStyle_When test method
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5274 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 639 640 +1
Lines 28777 28781 +4
Branches 4091 4092 +1
=======================================
+ Hits 28775 28779 +4
Partials 2 2 ☔ View full report in Codecov by Sentry. |
add BootstrapLabelSetting component
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5273
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Introduce the
BootstrapLabelSetting
component to cascade label settings, such asLabelWidth
, to child components likeBootstrapLabel
.New Features:
BootstrapLabelSetting
which allows cascading label settings to childBootstrapLabel
components.Tests:
BootstrapLabelSetting
component.