feat(ValidateForm): add LabelWidth parameter #5267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request introduces a new LabelWidth parameter to the ValidateForm component, allowing users to set the width of labels within the form. This parameter is cascaded down to the EditorForm component. Class diagram showing ValidateForm and EditorForm relationship with new LabelWidth parameterclassDiagram
class ValidateForm {
+bool? DisableAutoSubmitFormByEnter
+int? LabelWidth
+IOptions<JsonLocalizationOptions> Options
}
class EditorForm {
+int? LabelWidth
+OnParametersSet()
}
ValidateForm <-- EditorForm : cascades parameters
note for ValidateForm "Added LabelWidth parameter"
note for EditorForm "Inherits LabelWidth from ValidateForm"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please improve the PR description by filling out all relevant sections of the template and providing a clear English description of the purpose and impact of adding the LabelWidth parameter.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5267 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 639 639
Lines 28763 28765 +2
Branches 4085 4086 +1
=========================================
+ Hits 28763 28765 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add LabelWidth parameter
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符；如果有关联 Issue 请在下方填写相关编号
Description
fixes #5266
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
New Features:
LabelWidthparameter to theValidateFormcomponent to control the width of form labels.