-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(MultiSelect): support Flags attribute #5253
Conversation
Reviewer's Guide by SourceryThis pull request introduces support for the Flags attribute in the MultiSelect component, allowing it to handle enums with the Flags attribute. The changes include modifications to the MultiSelect component to correctly process and display selected values for Flags enums, and a new demo showcasing this functionality. Sequence diagram for MultiSelect Flags enum value settingsequenceDiagram
participant User
participant MultiSelect
participant EnumSystem
User->>MultiSelect: Select multiple enum values
MultiSelect->>EnumSystem: Check for FlagsAttribute
MultiSelect->>EnumSystem: Parse selected values
MultiSelect->>MultiSelect: Calculate combined value
Note over MultiSelect: Sum up enum values<br/>for Flags representation
MultiSelect->>MultiSelect: Update CurrentValue
Class diagram showing MultiSelect component changes for Flags supportclassDiagram
class MultiSelect {
+TValue CurrentValue
+string CurrentValueAsString
+List~SelectedItem~ SelectedItems
-Type ValueType
+SetValue() Task
+ResetRules() void
}
note for MultiSelect "Added Flags enum support"
class MultiSelectEnumFoo {
<<enumeration>>
One = 1
Two = 2
Three = 4
Four = 8
}
note for MultiSelectEnumFoo "New Flags enum for demo"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5253 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 639 639
Lines 28733 28752 +19
Branches 4080 4084 +4
=========================================
+ Hits 28733 28752 +19 ☔ View full report in Codecov by Sentry. |
support Flags attribute
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5239
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add support for the Flags attribute to the MultiSelect component.
New Features:
Tests: