feat(IDynamicObject): disable support complex object #5250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request disables support for complex objects in Sequence diagram showing property access flow with disabled complex object supportsequenceDiagram
participant C as Client
participant DO as DynamicObject
participant U as Utility
participant CM as CacheManager
C->>DO: GetValue(propertyName)
DO->>U: GetPropertyValue(this, propertyName, false)
U->>CM: GetPropertyValue(model, fieldName, false)
Note over CM: Complex property support disabled
CM-->>U: Simple property value
U-->>DO: Value
DO-->>C: Value
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5250 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 639 639
Lines 28771 28732 -39
Branches 4082 4080 -2
=========================================
- Hits 28771 28732 -39 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disable support complex object
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符；如果有关联 Issue 请在下方填写相关编号
Description
fixes #5249
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Refactor the GetPropertyValueLambda and SetPropertyValueLambda methods to disable support for complex properties by default, and add a parameter to control this behavior. Update the GetPropertyValue and SetPropertyValue methods in the Utility class to pass this parameter to the corresponding lambda methods. Update the DynamicObject, DataTableDynamicObject, and DataTableDynamicContext classes to use the new parameter when setting property values. Update the CreateCallback method in the Utility class to pass true for the supportComplexProperty parameter. Add a unit test to verify that complex properties are handled correctly when the supportComplexProperty parameter is set to false.
Bug Fixes:
Tests: