Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DropUpload): add DropUpload component #5236

Merged
merged 25 commits into from
Jan 29, 2025
Merged

feat(DropUpload): add DropUpload component #5236

merged 25 commits into from
Jan 29, 2025

Conversation

ArgoZhang
Copy link
Collaborator

@ArgoZhang ArgoZhang commented Jan 28, 2025

add DropUpload component

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #5224

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

New Features:

  • Introduce a new DropUpload component that allows users to upload files by dragging and dropping them or by clicking to select files.

@bb-auto bb-auto bot added the enhancement New feature or request label Jan 28, 2025
Copy link

sourcery-ai bot commented Jan 28, 2025

Reviewer's Guide by Sourcery

This pull request introduces a new DropUpload component, enhancing the file upload functionality. It includes styling updates, javascript changes, and a new razor component.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added DropUpload component with associated styling and functionality.
  • Created DropUpload.razor.cs with properties for customizing the component.
  • Created DropUpload.razor with the basic layout and structure.
  • Added new CSS variables and styles for the drop area in UploadBase.razor.scss.
  • Modified upload.js to include click event for the new drop area.
  • Added new scss variables for the drop area in bootstrapblazor.scss.
src/BootstrapBlazor/Components/Upload/DropUpload.razor.cs
src/BootstrapBlazor/Components/Upload/DropUpload.razor
src/BootstrapBlazor/Components/Upload/UploadBase.razor.scss
src/BootstrapBlazor/wwwroot/modules/upload.js
src/BootstrapBlazor/wwwroot/scss/theme/bootstrapblazor.scss
Updated the sample page to include the new DropUpload component.
  • Added a new DemoBlock for the DropUpload component in Uploads.razor.
src/BootstrapBlazor.Server/Components/Samples/Uploads.razor
Minor changes to other upload components and a sample page.
  • Added a try-catch block to the SynthesizerService in Synthesizers.razor.cs.
  • Added comments to the AvatarUpload.razor.cs, ButtonUpload.razor.cs, InputUpload.razor.cs, and SingleUploadBase.cs files.
src/BootstrapBlazor.Server/Components/Samples/Speeches/Synthesizers.razor.cs
src/BootstrapBlazor/Components/Upload/AvatarUpload.razor.cs
src/BootstrapBlazor/Components/Upload/ButtonUpload.razor.cs
src/BootstrapBlazor/Components/Upload/InputUpload.razor.cs
src/BootstrapBlazor/Components/Upload/SingleUploadBase.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#5224 Add a new DropUpload component to the library
#5224 Implement drag and drop file upload functionality
#5224 Provide a user-friendly interface for file uploads

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the v9.3.0 milestone Jan 28, 2025
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Jan 28, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The empty catch block in Synthesizers.razor.cs silently swallows exceptions. This could hide important errors from users and make debugging difficult. Consider at least logging the exception or showing an error message to users.
  • DropUpload.razor.cs contains a hardcoded footer string ('just a test footer string') that appears to be test/development code. This should be removed or replaced with a proper default value.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b6f47f0) to head (d247c66).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5236   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          635       637    +2     
  Lines        28248     28317   +69     
  Branches      4066      4078   +12     
=========================================
+ Hits         28248     28317   +69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 0099bd3 into main Jan 29, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the feat-upload branch January 29, 2025 04:20
@ArgoZhang ArgoZhang linked an issue Jan 29, 2025 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(DropUpload): add DropUpload component feat(InputUpload): add ShowProgress attribute
1 participant