-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Tab): add IsDisabled parameter #5200
Conversation
Reviewer's Guide by SourceryThis pull request introduces the IsDisabled parameter to the TabItem component, allowing individual tabs to be disabled. It also includes corresponding updates to the Tab component to handle disabled states, and adds a demo for the new functionality. Class diagram showing TabItem changes with IsDisabled parameterclassDiagram
class TabItem {
+bool IsActive
+bool IsDisabled
+bool IsCloseable
+SetActive(bool active)
+SetDisabled(bool disabled)
-SetDisabledWithoutRender(bool disabled)
}
class Tab {
+SetDisabledItem(TabItem item, bool disabled)
-GetClassString(TabItem item)
-RenderTabItemContent(TabItem item)
}
TabItem --> Tab: Uses
note for TabItem "Added IsDisabled property
and related methods"
note for Tab "Added support for
disabled state handling"
State diagram for TabItem statesstateDiagram-v2
[*] --> Enabled
Enabled --> Disabled: SetDisabled(true)
Disabled --> Enabled: SetDisabled(false)
state Enabled {
[*] --> Active
Active --> Inactive: SetActive(false)
Inactive --> Active: SetActive(true)
}
note right of Disabled: Cannot be activated
when disabled
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 2 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5200 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 634 634
Lines 28169 28190 +21
Branches 4053 4057 +4
=========================================
+ Hits 28169 28190 +21 ☔ View full report in Codecov by Sentry. |
Co-Authored-By: EliasIsmail <[email protected]>
# Conflicts: # src/BootstrapBlazor/BootstrapBlazor.csproj Co-Authored-By: EliasIsmail <[email protected]>
add IsDisabled parameter
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5198
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
New Features:
IsDisabled
parameter on theTabItem
component.