Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ICacheManager): add Keys parameter #5158

Merged
merged 2 commits into from
Jan 19, 2025
Merged

feat(ICacheManager): add Keys parameter #5158

merged 2 commits into from
Jan 19, 2025

Conversation

ArgoZhang
Copy link
Collaborator

@ArgoZhang ArgoZhang commented Jan 19, 2025

add Keys parameter

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #5157

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

New Features:

  • Added a Keys parameter to the ICacheManager interface to retrieve cache keys.

Copy link

sourcery-ai bot commented Jan 19, 2025

Reviewer's Guide by Sourcery

This pull request introduces a new Keys property to the ICacheManager interface and its implementation, allowing access to the cache keys. Additionally, a Count property was added to retrieve the number of items in the cache.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added a Count property to ICacheManager and CacheManager to get the number of items in the cache.
  • Added a Count property to the ICacheManager interface.
  • Implemented the Count property in the CacheManager class, returning the number of items in the underlying MemoryCache.
src/BootstrapBlazor/Services/CacheManager.cs
src/BootstrapBlazor/Services/ICacheManager.cs
Added a Keys property to ICacheManager and CacheManager to get the keys of the cached items.
  • Added a Keys property to the ICacheManager interface.
  • Implemented the Keys property in the CacheManager class, returning the keys of the underlying MemoryCache.
  • The Keys property is only available when the target framework is .NET 9 or greater.
src/BootstrapBlazor/Services/CacheManager.cs
src/BootstrapBlazor/Services/ICacheManager.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#5157 Add Keys parameter to ICacheManager

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Jan 19, 2025
@bb-auto bb-auto bot added this to the v9.2.0 milestone Jan 19, 2025
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Jan 19, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider implementing the Keys property for all .NET versions instead of limiting it to NET9_0_OR_GREATER. You can enumerate the keys manually for earlier versions to provide consistent functionality across framework versions.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c794a1e) to head (9737f83).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5158   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          635       635           
  Lines        28184     28200   +16     
  Branches      4039      4041    +2     
=========================================
+ Hits         28184     28200   +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 72868a6 into main Jan 19, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the feat-cache branch January 19, 2025 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(ICacheManager): add Keys parameter
1 participant