perf(CacheManager): remove lock improve performance

[ArgoZhang]

remove lock improve performance

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符；如果有关联 Issue 请在下方填写相关编号

Description

fixes #5153

Regression?

• Yes
• No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

• High
• Medium
• Low

[Justify the selection above]

Verification

• Manual (required)
• Automated

Packaging changes reviewed?

• Yes
• No
• N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

• Doc is updated/provided or not needed
• Demo is updated/provided or not needed
• Merge the latest code from the main branch

Summary by Sourcery

Remove the lock from the CacheManager to improve performance.

Bug Fixes:

• Fix an issue where the cache was not being updated correctly.

Enhancements:

• Improve the performance of the CacheManager by removing the lock.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request removes a lock from the CacheManager to improve performance. The lock was previously used to protect the cache from concurrent access, but it was determined that the cache is thread-safe and the lock is not necessary.

Sequence diagram showing simplified cache access flow after lock removal

sequenceDiagram
    participant Client
    participant CacheManager
    participant Cache

    Client->>CacheManager: GetAllStringsByTypeName(assembly, typeName)
    CacheManager->>Cache: GetOrCreate(key, valueFactory)
    Note right of Cache: No lock needed anymore
    Cache-->>CacheManager: Return localized items
    CacheManager-->>Client: Return filtered items

Loading

Class diagram showing CacheManager changes

classDiagram
    class CacheManager {
        -Cache Instance
        +GetAllStringsByTypeName(Assembly, string) IEnumerable~LocalizedString~
        +GetJsonStringByTypeName(JsonLocalizationOptions, Assembly, string, string) IEnumerable~LocalizedString~
    }
    note for CacheManager "Removed _locker field
Cache operations are now lockless"

Loading

File-Level Changes

Change	Details	Files
Removed the lock from the CacheManager.	Removed the _locker field. Removed the lock statement when creating or getting items from the cache.	src/BootstrapBlazor/Services/CacheManager.cs
Removed unnecessary exception.	Removed the InvalidOperationException from the GetResourcePrefix method.	src/BootstrapBlazor/Localization/Json/JsonStringLocalizerFactory.cs

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#5153	Remove locking mechanism to improve performance of CacheManager	✅
#5153	Optimize localization string retrieval process	✅

Possibly linked issues

• perf(CacheManager): remove lock improve performance #5153: The PR improves CacheManager performance by removing a lock, addressing the issue directly.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

• Please provide performance benchmarks demonstrating the improvement from removing the lock. This will help validate that the change achieves its intended goal without introducing any issues.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d0dd670) to head (f420e2f).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #5154   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          635       635           
  Lines        28187     28184    -3     
  Branches      4039      4039           
=========================================
- Hits         28187     28184    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.