-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(CacheManager): add cache by type #5152
Conversation
Reviewer's Guide by SourceryThis pull request refactors the JsonStringLocalizer to add a cache by type to improve performance. It also fixes a bug where missing resources were not being cached correctly. Sequence diagram for string localization processsequenceDiagram
participant Client
participant JsonStringLocalizer
participant Service
participant Cache
participant Json
Client->>JsonStringLocalizer: Get localized string
JsonStringLocalizer->>Service: GetStringFromService(name)
Service->>Cache: Check _missingManifestCache
alt Not in cache
Service->>Service: Get localized value
Service-->>JsonStringLocalizer: Return value if found
Service->>Cache: Cache missing resource
end
alt String not found in service
JsonStringLocalizer->>Json: GetStringSafelyFromJson(name)
Json->>Cache: Check _missingManifestCache
alt Not in cache
Json->>Json: Find in localizerStrings
Json-->>JsonStringLocalizer: Return value if found
Json->>Cache: Cache missing resource
end
end
JsonStringLocalizer-->>Client: Return localized string
Class diagram for JsonStringLocalizer changesclassDiagram
class JsonStringLocalizer {
-ConcurrentDictionary~string,object~ _missingManifestCache
-List~LocalizedString~ _allLocalizerdStrings
+LocalizedString this[string name]
-string GetStringSafely(string name)
-string GetStringFromService(string name)
-string GetStringSafelyFromJson(string name)
-List~LocalizedString~ MegerResolveLocalizers(IEnumerable~LocalizedString~ localizerStrings)
-string GetValueFromCache(List~LocalizedString~ localizerStrings, string name)
-void HandleMissingResourceItem(string name)
}
note for JsonStringLocalizer "Changed from HashSet to ConcurrentDictionary
for thread-safe caching"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a struct or tuple as cache key instead of string concatenation to improve performance. The current approach of
$"name={name}&culture={CultureInfo.CurrentUICulture.Name}"
creates unnecessary string allocations.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5152 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 635 635
Lines 28195 28187 -8
Branches 4039 4039
=========================================
- Hits 28195 28187 -8 ☔ View full report in Codecov by Sentry. |
add cache by type
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5151
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add caching for localized strings by type.
Bug Fixes:
Enhancements: