-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(LoadModule): add logger information for load module failed #5148
Conversation
Reviewer's Guide by SourceryThis pull request adds logging for when loading a JS module fails, which helps with debugging. It also adds a version parameter to the LoadUtility method. Sequence diagram for JS module loading with error handlingsequenceDiagram
participant App
participant JSRuntime
participant JSModule
participant Console
App->>JSRuntime: LoadModule(fileName, version)
JSRuntime->>JSModule: Import JS Module
alt Module Load Failed
JSModule-->>Console: Log error message
Note right of Console: New: Added logging for<br/>module load failures
JSModule-->>App: Throw JSException
else Module Load Success
JSModule-->>App: Return JSModule instance
end
Class diagram for JSModule and extensionsclassDiagram
class JSModule {
-IJSObjectReference jSObjectReference
+InvokeVoidAsync(string identifier, CancellationToken cancellationToken, params object?[]? args)
+InvokeAsync<TValue>(string identifier, CancellationToken cancellationToken, params object?[]? args)
}
class JSModuleExtensions {
+LoadUtility(IJSRuntime jsRuntime, string? version)*
+LoadModule(IJSRuntime jsRuntime, string fileName, string? version)*
}
note for JSModuleExtensions "Modified: Added version parameter
and enhanced error logging"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5148 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 634 634
Lines 28196 28191 -5
Branches 4038 4038
=========================================
- Hits 28196 28191 -5 ☔ View full report in Codecov by Sentry. |
add logger information for load module failed
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5147
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: