-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(AutoComplete): redesign value change logic #5130
Conversation
Co-Authored-By: celadaris <[email protected]>
# Conflicts: # src/BootstrapBlazor/BootstrapBlazor.csproj Co-Authored-By: celadaris <[email protected]>
Reviewer's Guide by SourceryThis PR refactors the AutoComplete component to redesign the value change logic. It renames the Sequence diagram for AutoComplete value change and filter logicsequenceDiagram
participant User
participant Input
participant AutoComplete
participant JSRuntime
Note over AutoComplete: New value change logic
alt User types in input
User->>Input: Types text
Input->>JSRuntime: composition event
JSRuntime->>AutoComplete: TriggerFilter(value)
AutoComplete->>AutoComplete: Filter items
AutoComplete->>AutoComplete: StateHasChanged()
else User changes value
User->>Input: Change value
Input->>JSRuntime: change event
JSRuntime->>AutoComplete: TriggerChange(value)
AutoComplete->>AutoComplete: Update CurrentValue
AutoComplete->>AutoComplete: StateHasChanged()
end
Class diagram for AutoComplete component changesclassDiagram
class AutoComplete {
-List~string~ FilterItems
-List~string~ Items
-List~string~ Rows
+Task TriggerFilter(string val)
+Task TriggerChange(string val)
-Task OnClickItem(string val)
}
note for AutoComplete "Split value change logic into
TriggerFilter and TriggerChange"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please provide a more detailed PR description explaining the motivation behind this refactoring and any potential breaking changes that users should be aware of.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5130 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 634 634
Lines 28174 28178 +4
Branches 4040 4040
=========================================
+ Hits 28174 28178 +4 ☔ View full report in Codecov by Sentry. |
redesign value change logic
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
link #5110
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Rename the
TriggerOnChange
method toTriggerFilter
and introduce a newTriggerChange
method. Update theAutoComplete
component to trigger value changes on thechange
event instead of thecomposition
event.New Features:
TriggerChange
method to theAutoComplete
component, which triggers value changes on thechange
event.Tests:
TriggerOnChange
toTriggerFilter
.