-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(CacheManager): GetJsonStringByTypeName prevent throw ArgumentNull exception #5106
fix(CacheManager): GetJsonStringByTypeName prevent throw ArgumentNull exception #5106
Conversation
Thanks for your PR, @densen2014. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Reviewer's Guide by SourceryThis pull request fixes a bug in the Class diagram showing LocalizedString handling in CacheManagerclassDiagram
class CacheManager {
-JsonLocalizationOptions GetJsonLocalizationOption()
+GetLocalizedString(string key)
}
class LocalizedString {
+string Key
+string Value
+bool ResourceNotFound
+string SearchedLocation
}
note for LocalizedString "Value now falls back to Key if null"
CacheManager ..> LocalizedString : creates
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @densen2014 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5106 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 634 634
Lines 28159 28165 +6
Branches 4039 4040 +1
=========================================
+ Hits 28159 28165 +6 ☔ View full report in Codecov by Sentry. |
CacheManager GetLocalizedString Key.Value Null
CacheManager GetLocalizedString Key.Value Null
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5103
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes:
CacheManager.GetLocalizedString
returned null values when the resource value was not found.