-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Light): support flash function when set IsFlat to true #5083
Conversation
Reviewer's Guide by SourceryThis PR adds support for the flash function when the IsFlat property of the Light component is set to true. It modifies the Light component to apply a flashing effect even when it is flat. It also updates the unit tests to cover the new functionality and modifies the related CSS styles. State diagram for Light component visual statesstateDiagram-v2
[*] --> Normal
Normal --> Flashing: IsFlash=true
Normal --> Flat: IsFlat=true
Flat --> FlatFlashing: IsFlash=true
state Flashing {
[*] --> On
On --> Off
Off --> On
}
state FlatFlashing {
[*] --> FlatOn
FlatOn --> FlatOff
FlatOff --> FlatOn
note right of FlatOn: New state added in PR
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5083 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 631 631
Lines 28012 28013 +1
Branches 4020 4020
=========================================
+ Hits 28012 28013 +1 ☔ View full report in Codecov by Sentry. |
support flash function when set IsFlat to true
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5082
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enable flash functionality for flat lights.
New Features:
Tests: