-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(Table): add sample code for row span #5080
Conversation
Reviewer's Guide by SourceryThis pull request adds a sample code for row span in the Table component by introducing a new component Class diagram for the new MergeTableRow componentclassDiagram
class MergeTableRow {
+TableRowContext<Foo> Context
}
class TableRowContext~T~ {
+T Row
}
MergeTableRow --> TableRowContext: uses
note for MergeTableRow "New component for
handling row spans
in Table component"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a brief comment in MergeTableRow.razor explaining the row spanning pattern being demonstrated
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5080 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 631 631
Lines 28012 28012
Branches 4020 4020
=========================================
Hits 28012 28012 ☔ View full report in Codecov by Sentry. |
add sample code for row span
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5079
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add sample code demonstrating how to use row spans in tables.
New Features:
MergeTableRow
component and aRowTemplate
.Tests:
MergeTableRow
component.