Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(Table): add sample code for row span #5080

Merged
merged 2 commits into from
Jan 9, 2025
Merged

doc(Table): add sample code for row span #5080

merged 2 commits into from
Jan 9, 2025

Conversation

ArgoZhang
Copy link
Collaborator

@ArgoZhang ArgoZhang commented Jan 9, 2025

add sample code for row span

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #5079

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Add sample code demonstrating how to use row spans in tables.

New Features:

  • Added support for merging rows in tables using a new MergeTableRow component and a RowTemplate.

Tests:

  • Added new tests for the MergeTableRow component.

@bb-auto bb-auto bot added the documentation Improvements or additions to documentation label Jan 9, 2025
@bb-auto bb-auto bot added this to the v9.2.0 milestone Jan 9, 2025
Copy link

sourcery-ai bot commented Jan 9, 2025

Reviewer's Guide by Sourcery

This pull request adds a sample code for row span in the Table component by introducing a new component MergeTableRow and updating the locale files.

Class diagram for the new MergeTableRow component

classDiagram
    class MergeTableRow {
        +TableRowContext<Foo> Context
    }
    class TableRowContext~T~ {
        +T Row
    }
    MergeTableRow --> TableRowContext: uses
    note for MergeTableRow "New component for
handling row spans
in Table component"
Loading

File-Level Changes

Change Details Files
Added a new component MergeTableRow to implement row merge in Table
  • Created MergeTableRow component.
  • Added parameters for row context.
  • Implemented logic to merge rows based on ID.
src/BootstrapBlazor.Server/Components/Components/MergeTableRow.razor
src/BootstrapBlazor.Server/Components/Components/MergeTableRow.razor.cs
Updated locale files
  • Added new locale keys for row span sample code titles and descriptions.
src/BootstrapBlazor.Server/Locales/en-US.json
src/BootstrapBlazor.Server/Locales/zh-CN.json
Updated TablesRow.razor with sample code for row span
  • Added a new demo block for row span.
  • Used the MergeTableRow component to demonstrate row merging.
  • Updated the existing demo block to use the new component.
src/BootstrapBlazor.Server/Components/Samples/Table/TablesRow.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#5079 Add sample code for row span in Table component documentation

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang enabled auto-merge (squash) January 9, 2025 10:16
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a brief comment in MergeTableRow.razor explaining the row spanning pattern being demonstrated
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9864a4f) to head (eb48854).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5080   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          631       631           
  Lines        28012     28012           
  Branches      4020      4020           
=========================================
  Hits         28012     28012           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 00e9170 into main Jan 9, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the doc-row-template branch January 9, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc(Table): add sample code for row span
1 participant