-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SelectTable): add IsClearable parameter #5074
Conversation
Reviewer's Guide by SourceryThis PR adds an Sequence diagram for clearing SelectTable valuesequenceDiagram
actor User
participant ST as SelectTable
participant CA as OnClearAsync
User->>ST: Click clear icon
activate ST
ST->>ST: OnClearValue()
alt OnClearAsync is set
ST->>CA: Execute OnClearAsync
end
ST->>ST: OnClickRowCallback(default)
ST-->>User: Value cleared
deactivate ST
Class diagram for SelectTable component changesclassDiagram
class SelectTable {
+bool IsClearable
+string ClearIcon
+Func~Task~ OnClearAsync
-bool GetClearable()
-string ClearClassString
-Task OnClearValue()
+string ClassName
}
note for SelectTable "Added clearable functionality"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 2 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5074 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 631 631
Lines 27969 27990 +21
Branches 4010 4015 +5
=========================================
+ Hits 27969 27990 +21 ☔ View full report in Codecov by Sentry. |
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider removing the empty changes to localization files (en-US.json and zh-CN.json) from the PR
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
add IsClearable parameter
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5069
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
New Features:
IsClearable
parameter to theSelectTable
component.