-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ScrollIntoView): use nearest value instead of center #5049
Conversation
Reviewer's Guide by SourceryThis PR refactors the scrollIntoView behavior to use "nearest" value instead of "center" for vertical alignment. This change improves scrolling behavior in several components, including AutoComplete, Select, Table, and TreeView, by ensuring the selected item is fully visible within the viewport. Sequence diagram for updated scrolling behavior in componentssequenceDiagram
participant User
participant Component
participant ScrollHandler
User->>Component: Keyboard navigation (Up/Down)
Component->>ScrollHandler: scrollIntoView()
Note over ScrollHandler: Changed block: 'center' to 'nearest'
ScrollHandler-->>Component: Scroll item into view
Component-->>User: Show selected item in viewport
Class diagram showing ScrollIntoView configuration changesclassDiagram
class AutoComplete {
-scrollIntoView(el, item)
+handleKeyUp()
}
class Select {
-scrollIntoView(el, item)
}
class TreeView {
+ScrollIntoViewOptions: ScrollIntoViewOptions?
+scroll(id, options)
}
class ScrollIntoViewOptions {
+behavior: string
+block: string
+inline: string
}
note for ScrollIntoViewOptions "block changed from 'center' to 'nearest'"
TreeView --> ScrollIntoViewOptions
AutoComplete --> ScrollIntoViewOptions
Select --> ScrollIntoViewOptions
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please document what manual testing was performed to verify the scrolling behavior changes across all affected components (AutoComplete, Table, Select, TreeView).
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
src/BootstrapBlazor/Components/AutoComplete/AutoComplete.razor.js
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5049 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 631 631
Lines 27964 27964
Branches 4008 4008
=========================================
Hits 27964 27964 ☔ View full report in Codecov by Sentry. |
@sourcery-ai review |
use nearest value instead of center
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5048
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enhancements: