Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Swal): upgrade swal v2 style #5026

Merged
merged 4 commits into from
Jan 2, 2025
Merged

feat(Swal): upgrade swal v2 style #5026

merged 4 commits into from
Jan 2, 2025

Conversation

ArgoZhang
Copy link
Collaborator

@ArgoZhang ArgoZhang commented Jan 2, 2025

upgrade swal v2 style

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #5025

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Update SweetAlert2 styles to match the latest version (v2).

Bug Fixes:

  • Fixed an issue where icons were not displayed correctly in SweetAlert2 popups.

Chores:

  • Updated SweetAlert2 CSS and related component code.

@bb-auto bb-auto bot added the enhancement New feature or request label Jan 2, 2025
@bb-auto bb-auto bot added this to the v9.2.0 milestone Jan 2, 2025
Copy link

sourcery-ai bot commented Jan 2, 2025

Reviewer's Guide by Sourcery

This PR upgrades the SweetAlert2 library and updates the styling to match the latest version. It also includes some minor fixes and improvements.

Class diagram for SweetAlert2 component changes

classDiagram
    class SweetAlertBody {
      +Category: SwalCategory
      +Title: string
      +IconTheme: IIconTheme
      -IconClassString: string
      +Show()
    }

    class SwalCategory {
      <<enumeration>>
      Success
      Error
      Warning
      Information
      Question
    }

    SweetAlertBody -- SwalCategory

    note for SweetAlertBody "Updated icon rendering and CSS classes"
Loading

State diagram for SweetAlert2 animation states

stateDiagram-v2
    [*] --> Normal
    Normal --> Show: swal2-show animation
    Show --> Hide: swal2-hide animation
    Hide --> [*]

    state Show {
      [*] --> IconShow
      IconShow --> Success: If success
      IconShow --> Error: If error
      Success --> SuccessAnimation: Animate lines
      Error --> ErrorAnimation: Animate X mark
    }

    note right of Show: New animation states
and transitions
Loading

File-Level Changes

Change Details Files
Updated SweetAlert2 CSS
  • Upgraded the SweetAlert2 CSS to the latest version.
  • Removed old CSS styles.
  • Added new CSS styles to match the latest SweetAlert2 version.
  • Updated CSS for toast messages to improve layout and responsiveness.
src/BootstrapBlazor/wwwroot/lib/swal/sweetalert2.css
Added SweetAlert style for different categories
  • Added specific CSS styles for warning, question, and information categories.
  • Added icons for warning, question, and information categories.
  • Updated SweetAlert component to use new CSS styles.
  • Updated sample code to demonstrate new styles.
src/BootstrapBlazor/Components/SweetAlert/SweetAlert.razor.scss
src/BootstrapBlazor/Components/SweetAlert/SweetAlertBody.razor
src/BootstrapBlazor/Components/SweetAlert/SweetAlertBody.razor.cs
src/BootstrapBlazor.Server/Components/Samples/SweetAlerts.razor
Updated SweetAlert2 library
  • Updated SweetAlert2 library to the latest version.
  • Updated minified CSS file.
src/BootstrapBlazor/BootstrapBlazor.csproj
src/BootstrapBlazor/wwwroot/lib/swal/sweetalert2.min.css

Assessment against linked issues

Issue Objective Addressed Explanation
#5025 Upgrade the styling of SweetAlert2 (Swal) to version 2 style

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang enabled auto-merge (squash) January 2, 2025 10:22
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please add documentation about the SweetAlert2 upgrade and any breaking style changes that users should be aware of when upgrading
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (62ade0b) to head (dbdd011).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5026   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          631       631           
  Lines        27951     27958    +7     
  Branches      4004      4007    +3     
=========================================
+ Hits         27951     27958    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 47d2463 into main Jan 2, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the feat-swal branch January 2, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(Swal): upgrade swal v2 style
1 participant