-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Swal): upgrade swal v2 style #5026
Conversation
Co-Authored-By: Alex chow <[email protected]>
Reviewer's Guide by SourceryThis PR upgrades the SweetAlert2 library and updates the styling to match the latest version. It also includes some minor fixes and improvements. Class diagram for SweetAlert2 component changesclassDiagram
class SweetAlertBody {
+Category: SwalCategory
+Title: string
+IconTheme: IIconTheme
-IconClassString: string
+Show()
}
class SwalCategory {
<<enumeration>>
Success
Error
Warning
Information
Question
}
SweetAlertBody -- SwalCategory
note for SweetAlertBody "Updated icon rendering and CSS classes"
State diagram for SweetAlert2 animation statesstateDiagram-v2
[*] --> Normal
Normal --> Show: swal2-show animation
Show --> Hide: swal2-hide animation
Hide --> [*]
state Show {
[*] --> IconShow
IconShow --> Success: If success
IconShow --> Error: If error
Success --> SuccessAnimation: Animate lines
Error --> ErrorAnimation: Animate X mark
}
note right of Show: New animation states
and transitions
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please add documentation about the SweetAlert2 upgrade and any breaking style changes that users should be aware of when upgrading
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5026 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 631 631
Lines 27951 27958 +7
Branches 4004 4007 +3
=========================================
+ Hits 27951 27958 +7 ☔ View full report in Codecov by Sentry. |
upgrade swal v2 style
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5025
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update SweetAlert2 styles to match the latest version (v2).
Bug Fixes:
Chores: