-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(AutoFill): add IsLikeMatch/IgnoreCase parameter #5014
Conversation
Reviewer's Guide by SourceryThis pull request adds two new parameters to the AutoFill component: Sequence diagram for AutoFill filtering behaviorsequenceDiagram
participant User
participant AutoFill
participant FilterItems
User->>AutoFill: Enter text
AutoFill->>AutoFill: TriggerOnChange(val)
alt Has CustomFilter
AutoFill->>AutoFill: OnCustomFilter(val)
else No CustomFilter
alt IsLikeMatch is true
AutoFill->>FilterItems: Filter with Contains
else IsLikeMatch is false
AutoFill->>FilterItems: Filter with StartsWith
end
Note over AutoFill,FilterItems: Apply IgnoreCase setting
end
AutoFill->>AutoFill: Apply DisplayCount limit
AutoFill-->>User: Show filtered results
Class diagram for AutoFill component changesclassDiagram
class AutoFill {
+bool IsLikeMatch
+bool IgnoreCase
+int? DisplayCount
+List~TValue~ Items
+List~TValue~ FilterItems
+TriggerOnChange(string val)
+OnParametersSet()
}
note for AutoFill "IsLikeMatch: Controls if filtering uses Contains or StartsWith
IgnoreCase: Controls case sensitivity of matching"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5014 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 631 631
Lines 27938 27946 +8
Branches 3998 4003 +5
=========================================
+ Hits 27938 27946 +8 ☔ View full report in Codecov by Sentry. |
add IsLikeMatch/IgnoreCase parameter
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5013
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add
IsLikeMatch
andIgnoreCase
parameters to theAutoFill
component to control string matching behavior.New Features:
IsLikeMatch
parameter to theAutoFill
component to enable like/fuzzy matching. When set totrue
, the component performs a contains search instead of a starts-with search.IgnoreCase
parameter to theAutoFill
component to control case sensitivity during matching.