-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ModalDialog): overflow top when set IsDraggable to true #4995
Conversation
Co-Authored-By: Ye Jiancong <[email protected]>
# Conflicts: # src/BootstrapBlazor/BootstrapBlazor.csproj Co-Authored-By: Ye Jiancong <[email protected]>
Reviewer's Guide by SourceryThis PR fixes a bug where the modal dialog overflows at the top when the Sequence diagram for Modal Dialog positioning calculationsequenceDiagram
participant M as Modal Dialog
participant JS as JavaScript
participant W as Window
M->>JS: init(id)
JS->>M: Get element
JS->>M: Get offsetHeight
JS->>W: Get innerHeight
JS->>M: Get computedStyle.marginTop
Note over JS: Calculate if modal fits in viewport
alt Modal fits in viewport
JS->>M: Set margin-top = 50vh - height
end
JS->>M: Set margin-left = 50vw - width
JS->>M: Remove 'is-draggable-center' class
State diagram for Modal Dialog positioning logicstateDiagram-v2
[*] --> CheckPosition
CheckPosition --> FitsInViewport: viewBoxHeight - height - marginTop > 0
CheckPosition --> DefaultPosition: viewBoxHeight - height - marginTop <= 0
FitsInViewport --> SetCenteredPosition: Set margin-top = 50vh - height
DefaultPosition --> KeepCurrentPosition
SetCenteredPosition --> UpdateHorizontalPosition
KeepCurrentPosition --> UpdateHorizontalPosition
UpdateHorizontalPosition --> RemoveDraggableCenter
RemoveDraggableCenter --> [*]
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please complete the PR template fully, including risk assessment and verification details. This helps maintainers better understand and review the changes.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4995 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 630 630
Lines 28099 28105 +6
Branches 4036 4030 -6
=========================================
+ Hits 28099 28105 +6 ☔ View full report in Codecov by Sentry. |
overflow top when set IsDraggable to true
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4994
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: