Porting System.Windows.Forms.Design.ListControlStringCollectionEditor #2078

vladimir-krestov · 2019-10-14T14:36:42Z

Fixes #1271
Related issue: #1115
Have you experienced this same bug with .NET Framework?: No

Proposed changes

Add System.Windows.Forms.Design.ListControlStringCollectionEditor class
Add resources for DataSourceLocksItem
Implement TypeForwardedTo method

Customer Impact

Changed collection editor for controls which use ListControlStringCollectionEditor (TextBox, ComboBox, ListBox, etc.) to compliance with .Net 4.8.

Regression?

No

Risk

No

Screenshots

Before

ComboBox (and others) has ObjectCollectionEditor as Items editor

After

ComboBox (and others) has ListControlStringCollectionEditor as Items editor

Test methodology

Manual UI testing

Test environment(s)

.Net Core version: 3.1.0-preview1.19458.7
Microsoft Windows [Version 10.0.18362.418]

Microsoft Reviewers: Open in CodeFlow

vladimir-krestov · 2019-10-14T14:39:25Z

Needs review before testing.

weltkante · 2019-10-14T14:46:41Z

Its probably not enough to just add the editor, it must be linked up with the TypeDescriptor. We've had a whole bunch of other editor porting issues (e.g. #1119, #1120, #1121) due to the editors not being linked up correctly. If possible we should do it correctly here in the first place instead of waiting for reports of it not working correctly.

vladimir-krestov · 2019-10-14T14:49:12Z

@weltkante, thank you, I'll check it.

codecov · 2019-10-14T14:58:31Z

Codecov Report

Merging #2078 into release/3.1 will increase coverage by 0.00596%.
The diff coverage is 0%.

@@                  Coverage Diff                  @@
##           release/3.1       #2078         +/-   ##
=====================================================
+ Coverage     26.50723%   26.51319%   +0.00596%     
=====================================================
  Files              806         806                 
  Lines           268108      268093         -15     
  Branches         38070       38069          -1     
=====================================================
+ Hits             71068       71080         +12     
+ Misses          191957      191933         -24     
+ Partials          5083        5080          -3

Flag	Coverage Δ
#Debug	`26.51319% <0%> (+0.00596%)`	⬆️
#production	`26.51319% <0%> (+0.00596%)`	⬆️
#test	`100% <ø> (?)`

weltkante · 2019-10-14T15:04:49Z

@vladimir-krestov sorry, I was overly cautious, this will probably just work, ListBox.Items already has the right attribute. I don't think this particular class is used outside WinForms so the comment regarding System.Drawing doesn't apply here.

vladimir-krestov · 2019-10-14T15:22:19Z

@weltkante , anyway, thank you for your information.

...ws.Forms.Design.Editors/src/System/Windows/Forms/Design/ListControlStringCollectionEditor.cs

zsd4yr

LGTM, a few nits

RussKie · 2019-10-15T03:37:41Z

Just to clarify, because the editor was originally defined in System.Design.dll we need to set type forwarding.

We can resolve nits later.

RussKie · 2019-10-16T02:30:49Z

📢 Please note due to a limited timeframe and the scope of work we are going to expediate all UI type editors ports into 3.1 and are going to ignore all stylistic review points.
All cleanup work is welcome on the master branch.

RussKie · 2019-10-16T02:31:06Z

@vladimir-krestov please rebase to resolve the MC

vladimir-krestov · 2019-10-16T07:10:35Z

Rebased to the latest release branch.
Fixed merge conflicts.

src/System.Design/src/System.Design.Forwards.cs

merriemcgaw · 2019-10-21T21:05:00Z

approved from my end. Please add the servicing: consider label after testing completes.

vladimir-krestov · 2019-10-23T09:09:43Z

Rebased to dev/3.1-uitypeeditors branch.
Added TypeForwardedTo for ListControlCollectionEditor according to #2078 (comment)

vladimir-krestov · 2019-10-23T14:16:12Z

@RussKie and @zsd4yr I need your approval before testing.

RussKie · 2019-10-24T06:19:18Z

src/System.Design/src/System.Design.Forwards.cs

+
+using System.Runtime.CompilerServices;
+
+[assembly: TypeForwardedTo(typeof(System.Windows.Forms.Design.ListControlStringCollectionEditor))]


I think we still need StringCollectionEditor and ArrayEditor...

Whilst we do not support nor cant be expected to support customers who reference our internals, in some scenarios like `UITypeEditor`s and `TypeConverter`s may still be used by consumers to enhance their runtime experience. E.g. dotnet#2078 (comment) Type forward `DataMemberFieldConverter` to avoid breaking existing customers. Relates to dotnet#1545

Whilst we do not support nor cant be expected to support customers who reference our internals, in some scenarios like `UITypeEditor`s and `TypeConverter`s may still be used by consumers to enhance their runtime experience. E.g. #2078 (comment) Type forward `DataMemberFieldConverter` to avoid breaking existing customers. Relates to #1545

vladimir-krestov requested a review from a team as a code owner October 14, 2019 14:36

vladimir-krestov self-assigned this Oct 14, 2019

This comment has been minimized.

Sign in to view

zsd4yr reviewed Oct 14, 2019

View reviewed changes

...ws.Forms.Design.Editors/src/System/Windows/Forms/Design/ListControlStringCollectionEditor.cs Outdated Show resolved Hide resolved

zsd4yr reviewed Oct 14, 2019

View reviewed changes

...ws.Forms.Design.Editors/src/System/Windows/Forms/Design/ListControlStringCollectionEditor.cs Outdated Show resolved Hide resolved

zsd4yr previously approved these changes Oct 14, 2019

View reviewed changes

RussKie previously approved these changes Oct 15, 2019

View reviewed changes

RussKie added waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) and removed waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) labels Oct 15, 2019

RussKie mentioned this pull request Oct 16, 2019

Review: all editors derived from UITypeEditor ported #1115

Open

73 tasks

vladimir-krestov dismissed stale reviews from RussKie and zsd4yr via 7212336 October 16, 2019 07:08

vladimir-krestov force-pushed the dev/v-vlkres/StringCollectionEditor branch from f9064da to 7212336 Compare October 16, 2019 07:08

RussKie reviewed Oct 16, 2019

View reviewed changes

src/System.Design/src/System.Design.Forwards.cs Show resolved Hide resolved

RussKie reviewed Oct 18, 2019

View reviewed changes

src/System.Design/src/System.Design.Forwards.cs Show resolved Hide resolved

vladimir-krestov changed the title ~~Porting System.Windows.Forms.Design.ListControlStringCollectionEditor~~ WIP: [Review] Porting System.Windows.Forms.Design.ListControlStringCollectionEditor Oct 18, 2019

RussKie mentioned this pull request Oct 21, 2019

Port IconEditor; add test #2089

Merged

vladimir-krestov added 🚧 work in progress Work that is current in progress and removed waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) labels Oct 21, 2019

RussKie mentioned this pull request Oct 23, 2019

Partially revert "Porting DataMemberFieldConverter" f477b2a #2154

Merged

vladimir-krestov force-pushed the dev/v-vlkres/StringCollectionEditor branch from 972f7fb to e5ee0d0 Compare October 23, 2019 08:08

vladimir-krestov changed the base branch from release/3.1 to dev/3.1-uitypeeditors October 23, 2019 08:10

vladimir-krestov force-pushed the dev/v-vlkres/StringCollectionEditor branch from 6b1ac54 to c66cfff Compare October 23, 2019 14:04

Ported ListControlStringCollectionEditor

9833f86

vladimir-krestov force-pushed the dev/v-vlkres/StringCollectionEditor branch from c66cfff to 9833f86 Compare October 23, 2019 14:05

vladimir-krestov changed the title ~~WIP: [Review] Porting System.Windows.Forms.Design.ListControlStringCollectionEditor~~ Porting System.Windows.Forms.Design.ListControlStringCollectionEditor Oct 23, 2019

vladimir-krestov added waiting-review This item is waiting on review by one or more members of team and removed 🚧 work in progress Work that is current in progress labels Oct 23, 2019

This was referenced Oct 23, 2019

TypeConverter Attribute over DataGridViewColumn.DataPropertyName should resolve to System.Design #2171

Closed

Write test(s) to ensure that all TypeConverter and Editor Attributes on internals are properly routed #2172

Open

zsd4yr approved these changes Oct 23, 2019

View reviewed changes

RussKie approved these changes Oct 24, 2019

View reviewed changes

RussKie removed the waiting-review This item is waiting on review by one or more members of team label Oct 24, 2019

RussKie reviewed Oct 24, 2019

View reviewed changes

RussKie merged commit 32783a2 into dev/3.1-uitypeeditors Oct 24, 2019

RussKie deleted the dev/v-vlkres/StringCollectionEditor branch October 28, 2019 11:56

RussKie mentioned this pull request Nov 5, 2019

Porting several outstanding UITypeEditors #2288

Merged

RussKie mentioned this pull request Nov 14, 2019

Port ColumnHeaderCollectionEditor #2345

Merged

ghost locked as resolved and limited conversation to collaborators Feb 3, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Porting System.Windows.Forms.Design.ListControlStringCollectionEditor #2078

Porting System.Windows.Forms.Design.ListControlStringCollectionEditor #2078

vladimir-krestov commented Oct 14, 2019 •

edited by ghost

Loading

vladimir-krestov commented Oct 14, 2019

weltkante commented Oct 14, 2019 •

edited

Loading

vladimir-krestov commented Oct 14, 2019

This comment has been minimized.

codecov bot commented Oct 14, 2019 •

edited

Loading

weltkante commented Oct 14, 2019 •

edited

Loading

vladimir-krestov commented Oct 14, 2019

zsd4yr left a comment

RussKie commented Oct 15, 2019

RussKie commented Oct 16, 2019

RussKie commented Oct 16, 2019

vladimir-krestov commented Oct 16, 2019

merriemcgaw commented Oct 21, 2019

vladimir-krestov commented Oct 23, 2019

vladimir-krestov commented Oct 23, 2019

RussKie Oct 24, 2019


		using System.Runtime.CompilerServices;

		[assembly: TypeForwardedTo(typeof(System.Windows.Forms.Design.ListControlStringCollectionEditor))]

Porting System.Windows.Forms.Design.ListControlStringCollectionEditor #2078

Porting System.Windows.Forms.Design.ListControlStringCollectionEditor #2078

Conversation

vladimir-krestov commented Oct 14, 2019 • edited by ghost Loading

Proposed changes

Customer Impact

Regression?

Risk

Screenshots

Before

After

Test methodology

Test environment(s)

Microsoft Reviewers: Open in CodeFlow

vladimir-krestov commented Oct 14, 2019

weltkante commented Oct 14, 2019 • edited Loading

vladimir-krestov commented Oct 14, 2019

This comment has been minimized.

codecov bot commented Oct 14, 2019 • edited Loading

Codecov Report

weltkante commented Oct 14, 2019 • edited Loading

vladimir-krestov commented Oct 14, 2019

zsd4yr left a comment

Choose a reason for hiding this comment

RussKie commented Oct 15, 2019

RussKie commented Oct 16, 2019

RussKie commented Oct 16, 2019

vladimir-krestov commented Oct 16, 2019

merriemcgaw commented Oct 21, 2019

vladimir-krestov commented Oct 23, 2019

vladimir-krestov commented Oct 23, 2019

RussKie Oct 24, 2019

Choose a reason for hiding this comment

vladimir-krestov commented Oct 14, 2019 •

edited by ghost

Loading

weltkante commented Oct 14, 2019 •

edited

Loading

codecov bot commented Oct 14, 2019 •

edited

Loading

weltkante commented Oct 14, 2019 •

edited

Loading