Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten long inline comments REVIEW (4th) DRAFT #12139

Draft
wants to merge 976 commits into
base: main
Choose a base branch
from

Conversation

paul1956
Copy link
Contributor

@paul1956 paul1956 commented Sep 14, 2024

Shorten long inline comments

Proposed changes

  • Wrap and in some cases move up a line, long inline comments.

Customer Impact

  • None

Regression?

  • No

Risk

  • None - no code changes
Microsoft Reviewers: Open in CodeFlow

@paul1956 paul1956 requested a review from a team as a code owner September 14, 2024 02:00
Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 91.94545% with 313 lines in your changes missing coverage. Please review.

Project coverage is 76.38263%. Comparing base (2261fa0) to head (33a7c7f).

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12139         +/-   ##
===================================================
+ Coverage   76.17780%   76.38263%   +0.20483%     
===================================================
  Files           3193        3200          +7     
  Lines         640306      643810       +3504     
  Branches       47237       47488        +251     
===================================================
+ Hits          487771      491759       +3988     
+ Misses        149008      148507        -501     
- Partials        3527        3544         +17     
Flag Coverage Δ
Debug 76.38263% <91.94545%> (+0.20483%) ⬆️
integration 18.12525% <6.82692%> (-0.03595%) ⬇️
production 50.41430% <75.07191%> (+0.30357%) ⬆️
test 97.03259% <98.13577%> (+0.01227%) ⬆️
unit 47.84891% <69.51103%> (+0.31431%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik Tanya-Solyanik added the draft draft PR label Sep 14, 2024
@dotnet-policy-service dotnet-policy-service bot removed the draft draft PR label Sep 15, 2024
@paul1956 paul1956 changed the title Shorten long inline comments DRAFT Shorten long inline comments REVIEW (5th) DRAFT Sep 16, 2024
@paul1956 paul1956 changed the title Shorten long inline comments REVIEW (5th) DRAFT Shorten long inline comments REVIEW (4th) DRAFT Sep 19, 2024
@paul1956
Copy link
Contributor Author

@Tanya-Solyanik could you set this one to draft please.

…' into Shorten-long-inline-comments-Review-4th
…' into Shorten-long-inline-comments-Review-4th
…' into Shorten-long-inline-comments-Review-4th
…' into Shorten-long-inline-comments-Review-4th
The server will now write issues as text to a public property ServerFault. The tests can then verify that there were no protocal issues except here expected.
…' into Shorten-long-inline-comments-Review-4th
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft draft PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants