Skip to content

Lift VMR's eng/versions.props to PSB in source only builds #48604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

Lift VMR's eng/versions.props to PSB in source only builds #48604

merged 1 commit into from
Apr 22, 2025

Conversation

MichaelSimons
Copy link
Member

@MichaelSimons MichaelSimons requested review from a team as code owners April 21, 2025 19:36
Copilot
Copilot AI reviewed Apr 21, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • src/SourceBuild/content/eng/Versions.props: Language not supported
  • src/SourceBuild/content/eng/tools/Directory.Build.props: Language not supported

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Apr 21, 2025
@ViktorHofer
Copy link
Member

@MichaelSimons I'm going to hit the merge button here and resolve the conflict in #47076 to save Jeremy some time. Hope that's OK.

@ViktorHofer ViktorHofer merged commit e46a50d into dotnet:main Apr 22, 2025
41 checks passed
@MichaelSimons MichaelSimons deleted the lift-vmr-versions.props branch April 22, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@NikolaMilosavljevic NikolaMilosavljevic NikolaMilosavljevic approved these changes

@mmitche mmitche Awaiting requested review from mmitche

@mthalman mthalman Awaiting requested review from mthalman

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelSimons @ViktorHofer @NikolaMilosavljevic