Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate Signing on Mac + Linux #46652

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Validate Signing on Mac + Linux #46652

merged 2 commits into from
Feb 18, 2025
+55 −11

Conversation

ellahathaway
Copy link
Member

@ellahathaway ellahathaway commented Feb 7, 2025 •
edited
Loading

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Feb 7, 2025
@ellahathaway
Copy link
Member Author

ellahathaway commented Feb 7, 2025 •
edited
Loading

This will have to wait until we do a rebootstrap. This is because the VMR’s global.json is on an arcade version that does not include my changes to enable SignCheck on .NET core. Because the version in global.json is the tooling version of arcade that gets restored, the version of SignCheck being restored is too low for this PR.

@ellahathaway
Copy link
Member Author

I will publish this once #46829 has been merged.

This was referenced Feb 14, 2025
Open
Open
Open
@ellahathaway ellahathaway marked this pull request as ready for review February 18, 2025 01:10
@Copilot Copilot bot review requested due to automatic review settings February 18, 2025 01:10
@ellahathaway ellahathaway requested review from a team as code owners February 18, 2025 01:10
@ellahathaway ellahathaway requested a review from mmitche February 18, 2025 01:10
Copilot
Copilot AI reviewed Feb 18, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
@ellahathaway
Copy link
Member Author

@dotnet/product-construction - can I please get help merging this PR? The failures are unrelated to my changes. Thanks!

@ViktorHofer ViktorHofer merged commit c809396 into dotnet:main Feb 18, 2025
37 of 40 checks passed
@ellahathaway ellahathaway deleted the signcheck.nonwindows branch February 18, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@MichaelSimons MichaelSimons MichaelSimons approved these changes

@mmitche mmitche Awaiting requested review from mmitche

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable signing validation on non-Windows shipping VMR outputs
3 participants
@ellahathaway @ViktorHofer @MichaelSimons