-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable test timeout dump collection #44730
base: release/9.0.1xx
Are you sure you want to change the base?
Conversation
…et test for both full framework and not
…h the dotnet test format
This doesn't appear to work on non-windows: And any test that requires msbuildforwardingapp doesn't appear to work correctly within the dotnet test execution. Applying a fix for the path variable as it was adding quotes that weren't meant to be there. |
@dsplaisted some of the other failures doing this are because we end up getting the host from the environment but that's now testhost.exe: https://github.com/dotnet/sdk/blob/main/src/Cli/Microsoft.DotNet.Cli.Utils/ForwardingAppImplementation.cs#L99 Is there a better way to find dotnet.exe that we already have in our test infrastructure? |
illink (and few other tools in runtime repo) finds it via |
I do not know the history on why we launch our tests with dotnet-exec. We may hae to change the arguments to match the above commands that we use on netfx (and simplify to just use one).
I'm starting with this just to see if it'll work.
Also open question is where will the dump end up.