Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp Orleans shopping cart example | .NET 8 + Azure Cosmos DB for NoSQL #6213

Merged

Conversation

seesharprun
Copy link
Contributor

@seesharprun seesharprun commented Oct 4, 2023

Changes:

  • Change package versions from static to floating (ex. 7.x)
  • Pushed forward to .NET 8
  • Ran dotnet format
  • Updated Mud icons to fix deprecation warnings
  • Added null checking-ignore to connection string
  • Removed port metadata (not needed for sample app)
  • Revamped Program.cs to match the Orleans quickstart
  • Implement Azure Cosmos DB for NoSQL grain persistence
  • Fix error where application is publishing to Port 8080 on Azure Container Apps
  • Add permanent Dockerfile and .dockerignore
  • Updated readme

Related to dotnet/docs#36975

@seesharprun
Copy link
Contributor Author

@IEvangelist and @bradygaster, this sample will be ready for review next week after I add the Dockerfile

@seesharprun seesharprun marked this pull request as ready for review October 18, 2023 13:34
@seesharprun seesharprun requested a review from a team as a code owner October 18, 2023 13:34
@seesharprun
Copy link
Contributor Author

seesharprun commented Oct 18, 2023

@IEvangelist, How do you feel about a floating version resolution?

<PackageReference Include="Microsoft.Orleans.Server" Version="8.*-*" />

That syntax should cover both pre-release and release variants of 8.x

I use this technique for Azure.AI.OpenAI over in our Cosmos+OpenAI sample:

@seesharprun seesharprun marked this pull request as draft October 18, 2023 18:09
@IEvangelist
Copy link
Member

IEvangelist commented Oct 18, 2023

@IEvangelist, How do you feel about a floating version resolution?

<PackageReference Include="Microsoft.Orleans.Server" Version="8.*-*" />

That syntax should cover both pre-release and release variants of 8.x

I use this technique for Azure.AI.OpenAI over in our Cosmos+OpenAI sample:

@seesharprun - The 8.* works the exact same way, it will allow use to reference 8.0.0-rc.2 bits and when 8.0.0 happens it will resolve as that.

@IEvangelist IEvangelist marked this pull request as ready for review January 5, 2024 20:47
@IEvangelist IEvangelist enabled auto-merge (squash) January 5, 2024 20:48
@IEvangelist IEvangelist merged commit c04cd19 into dotnet:main Jan 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants