Skip to content

[release/7.0-staging] [tests] Disables tests on Apple mobile platforms #95861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 11, 2023

Backport of #95757 to release/7.0-staging

/cc @kotlarmilos

Customer Impact

Issue #88049 was opened by a team member.

This PR disables failing tests on Apple mobile platforms. The tests utilize a temporary directory that exceeds the path length limit. There is no customer impact. This change is for testing only.

Testing

The fix was tested on the main branch by executing the tests on the CI.

Risk

Low risk. It only disables library tests on Apple mobile platforms and does not involve any modifications to the runtime.

The change doesn't affect code that ships in a NuGet package.

@ghost
Copy link

ghost commented Dec 11, 2023

Tagging subscribers to this area: @dotnet/area-system-formats-tar
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #95757 to release/7.0-staging

/cc @kotlarmilos

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Formats.Tar

Milestone: -

@kotlarmilos kotlarmilos self-assigned this Dec 11, 2023
@kotlarmilos kotlarmilos added the os-ios Apple iOS label Dec 11, 2023
@ghost
Copy link

ghost commented Dec 11, 2023

Tagging subscribers to 'os-ios': @steveisok, @akoeplinger, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #95757 to release/7.0-staging

/cc @kotlarmilos

Customer Impact

Issue #88049 was opened by a team member.

This PR disables failing tests on Apple mobile platforms. The tests utilize a temporary directory that exceeds the path length limit. There is no customer impact. This change is for testing only.

Testing

The fix was tested on the main branch by executing the tests on the CI.

Risk

Low risk. It only disables library tests on Apple mobile platforms and does not involve any modifications to the runtime.

The change doesn't affect code that ships in a NuGet package.

Fixes #88049

Author: github-actions[bot]
Assignees: kotlarmilos
Labels:

os-ios, area-System.Formats.Tar

Milestone: -

@ericstj
Copy link
Member

ericstj commented Dec 12, 2023

Test only changes don't require ask-mode. Marking this as approved.

@ericstj ericstj added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Dec 12, 2023
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your help figuring this out.

@carlossanlop
Copy link
Contributor

Failures unrelated. Merging now.

@carlossanlop carlossanlop merged commit ec675fb into release/7.0-staging Dec 12, 2023
@carlossanlop carlossanlop deleted the backport/pr-95757-to-release/7.0-staging branch December 12, 2023 18:04
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Formats.Tar os-ios Apple iOS Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mono][ios] System.Formats.Tar.Tests are failing with System.ArgumentException
3 participants