-
Notifications
You must be signed in to change notification settings - Fork 5k
[Mono] UnsafeAccessorAttribute non-generic support for field #88626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
bc9d6ed
Detect an UnsafeAccessorAttribute for method with interpreter
fanyang-mono 1643710
Change field to property
fanyang-mono b0def6c
Get Kind from typed_args
fanyang-mono 0c51e8a
define MonoUnsafeAccessorKind enum
lambdageek 94ce7d2
Add the frontend for JIT
fanyang-mono a49a8e0
Add mono_marshal_get_unsafe_accessor_wrapper and WRAPPER_SUBTYPE_UNSA…
lambdageek 4701689
[interp] get the unsafe accessor wrapper
lambdageek 495ce38
fix: skip visibility in unsafe accessor wrappers
lambdageek 35c4d45
fix: decode the length and copy the name from UnsafeAccessorAttribute
lambdageek 0c8f4da
[mini] compile wrapper
lambdageek 8d039e6
[aot] Emit unsafe accessor wrappers to the AOT image
lambdageek 080559a
Add the method to emit wrapper for field
fanyang-mono 2ec266b
Fix typo
fanyang-mono 8571969
Remove assertion for interpreter
fanyang-mono b7e35c6
Fix format and replace assertion with proper exception
fanyang-mono 449aa6f
Free the memory and throw proper NotImplementedException
fanyang-mono da84576
Enable StaticField and Field tests
fanyang-mono 23a4d9a
Remove unused variables
fanyang-mono 342c8d4
Only allow static method
fanyang-mono 375d460
Return immediately once hit an exception
fanyang-mono 9222fd2
Free cinfo at the right location
fanyang-mono ab2e8c5
Disable test, cause Constructor kind is not supported yet.
fanyang-mono 2f8031a
Stop inlining UnsafeAccessor wrapper for interpreter
fanyang-mono 10e43de
Merge branch 'main' into unsafeAccessor
fanyang-mono 4d874c3
Revert inlining change
fanyang-mono ade7c78
Update exception message
fanyang-mono 58822ca
Fix loading static field and add static status check and a test
fanyang-mono 3686590
Add another test and address feedback
fanyang-mono 8afb00a
Update src/tests/baseservices/compilerservices/UnsafeAccessors/Unsafe…
fanyang-mono a3f9e77
Update src/tests/baseservices/compilerservices/UnsafeAccessors/Unsafe…
fanyang-mono 9f6b532
Update src/tests/baseservices/compilerservices/UnsafeAccessors/Unsafe…
fanyang-mono 0c15ccd
Update src/tests/baseservices/compilerservices/UnsafeAccessors/Unsafe…
fanyang-mono f21b78e
Update src/tests/baseservices/compilerservices/UnsafeAccessors/Unsafe…
fanyang-mono 781f512
Address more review feedback
fanyang-mono 17febef
Fix function call to field
fanyang-mono File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.