Implementing GetElement, ToScalar, and WithElement for Vector512 #84791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue Detailsnull
|
tannergooding
force-pushed
the
avx512-getwith-element
branch
from
f546e8e to
ae54e5f
Compare
tannergooding
force-pushed
the
avx512-getwith-element
branch
from
ae54e5f to
9aeb453
Compare
|
CC. @dotnet/avx512-contrib, @dotnet/jit-contrib |
EgorBo
reviewed
Apr 14, 2023
| @@ -11241,7 +11241,7 @@ void emitter::emitDispIns( | |||
|
|
|||
| case IF_RWR_RRD_RRD: | |||
| { | |||
| assert(IsVexEncodableInstruction(ins)); | |||
| assert(IsVexOrEvexEncodableInstruction(ins)); | |||
There was a problem hiding this comment.
heh, I hit it in #84854 too 🙂 will rebase once your PR is merged
EgorBo
approved these changes
Apr 14, 2023
|
btw, @BruceForstall asked to not to merge JIT-related PRs untill jit rolling builds are fixed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.